Add emit_result_slice_pointer option for :many queries#11
Open
Alexfilus wants to merge 1 commit intosqlc-dev:mainfrom
Open
Add emit_result_slice_pointer option for :many queries#11Alexfilus wants to merge 1 commit intosqlc-dev:mainfrom
Alexfilus wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_result_slice_pointeroption that changes:manyquery signature to accept a destination slice pointer instead of returning a new slicefunc(..., dest *[]T) errorinstead offunc(...) ([]T, error)Example
Default behavior (
emit_result_slice_pointer: false):With
emit_result_slice_pointer: true:Changes
internal/opts/options.go: AddedEmitResultSlicePointeroptioninternal/gen.go: Wired option to template contextinternal/templates/pgx/queryCode.tmpl: Added conditional template for new behaviorTest plan
make allmake test- all tests pass🤖 Generated with Claude Code